Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of memory errors should be real errors #80

Open
TysonAndre opened this issue Oct 2, 2022 · 0 comments · May be fixed by #81
Open

Out of memory errors should be real errors #80

TysonAndre opened this issue Oct 2, 2022 · 0 comments · May be fixed by #81
Labels
bug Something isn't working

Comments

@TysonAndre
Copy link
Collaborator

Related to #65

simdjson_is_valid(): bool and other PHP bindings would unpredictably be false if the OS was out of memory

E.g. use zend_error_noreturn to terminate the process
@TysonAndre TysonAndre added the bug Something isn't working label Oct 2, 2022
TysonAndre added a commit to TysonAndre/simdjson_php that referenced this issue Oct 2, 2022
@TysonAndre
Improve buffer reuse. Check for out of memory error code
26149a3 
Closes crazyxman#80 - simdjson_is_valid() and other PHP functions would
previously return false when out of memory

- Related to crazyxman#60 - other php apis (using emalloc instead) will also emit
  fatal errors when out of memory and end the process.

Closes crazyxman#79 - reuse buffers for strings less than 1000000 bytes and
100000 depth. (Assumes the depth rarely changes in callers)
@TysonAndre TysonAndre linked a pull request Oct 2, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve buffer reuse. Check for out of memory error code TysonAndre/simdjson_php
1 participant
@TysonAndre