-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PHP RFC #8
Comments
Hi @crazyxman, I've just provided a PR to php-src in order to bundle your extension to the core: php/php-src#6551 and started a discussion about it: https://externals.io/message/112638 |
In case it's not accepted into PHP would you consider making it available via PECL? |
Yes, it's most probably won't be accepted just yet. But in this case, I'll try my best to make it available via PECL, sure. |
@kocsismate thank you very much! It is a good idea to make it available through PECL |
@kocsismate I'm looking forward for your support to make it available via pecl and to improve this PHP extension. |
In the light of the mailing list discussion (https://externals.io/message/112638), I abandon my proposal, as people would rather prefer to use libsimdjson as an optional JSON parsing backend. |
do we have any news on progress regarding making it available through PECL? |
People in the ML suggested to make simdjson available as a parsing backend for the built-in json-related functions, so if I tried to work on this, then I would rather follow this approach, instead of creating a new PECL extension. |
That seems viable once implemented and the test cases of edge cases pass - if simdjson fails to parse it, then the exception should be cleared and json_decode() can fall back to the original json implementation so that https://www.php.net/json_last_error and JSON_THROW_ON_ERROR will work as expected and valid inputs would be permitted with flags such as JSON_BIGINT_AS_STRING
|
The pecl simdjson 3.0.0 release should be in a good state (including for zts releases) for proposing to include as a configure option in php 8.3 This will speed up the happy path, where the json string is valid json (see previous comment for error handling).
I'd still need to fix #81 |
Could you create RFC to maybe implement this into PHP? The speed imporovement is impressive and would improve PHP itself.
https://wiki.php.net/rfc
The text was updated successfully, but these errors were encountered: