Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing typing to increase compatibility #12

Open
AntiSol opened this issue Aug 11, 2024 · 0 comments
Open

consider removing typing to increase compatibility #12

AntiSol opened this issue Aug 11, 2024 · 0 comments

Comments

@AntiSol
Copy link

AntiSol commented Aug 11, 2024

Hello,

Thank you for this plugin, it's exactly what I was looking for..........almost.

I was able to make this work with blender 2.8 with minimal changes, mostly removing new-style type annotations like list[x], use of typing union operator |, and one place where you're using a case statement. See: here

You should consider using less bleeding-edge language features to increase compatibility for your code - not everybody can easily use the latest bleeding-edge version of blender/python, and you gain nothing by using these features except making your code less compatible.

I've refrained from raising a PR because I think it's unlikely to get anywhere (and because I've simply removed typing rather than e.g using the typing library's Union/Dict/List/Tuple classes because I was in a hurry and because that's my preference), but I thought you might be interested. I'm happy to raise a PR if you'd like me to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant