Contact Form Submission - Mistake (Advanced - Sum over Subsets DP)

[maggieliu05]

Someone submitted the contact form!

URL: https://usaco.guide/adv/dp-sos?lang=cpp
Module: Advanced - Sum over Subsets DP
Topic: Mistake
Message:
There is a mistake in the https://usaco.guide/adv/dp-sos section in the optimized sum of subsets dp code. Before, I found a mistake in the 3^n solution where it would infinite loop. That is fixed now but in the 2^n solution the code accesses indicies -1 in c++. Running the code makes a segfault. I think if you re-index the vector to start from -1 it should work.

[bqi343]

Also, the module should really include an implementation that performs the sos operation in-place rather than initializing a new 2D array of size $2^N \cdot N$

[bqi343]

@ryanchou-dev @SansPapyrus683 How did this line pass review?

https://github.com/cpinitiative/usaco-guide/pull/3630/files#diff-0211bda77e597b8aab208c57f719d39d03a27bd27598f291b4c3cbc1d9703173R112

[bqi343]

Also, this should be in the Platinum section considering there are multiple USACO Platinum problems in this module.

[SansPapyrus683]

How did this line pass review?

that's a great question