Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor documentation issues (missing verb, closing parenthesis) #133

Open
richlv opened this issue Feb 4, 2019 · 0 comments
Open

minor documentation issues (missing verb, closing parenthesis) #133

richlv opened this issue Feb 4, 2019 · 0 comments

Comments

@richlv
Copy link

richlv commented Feb 4, 2019

and it both painful and a bit dangerous to close all open file descriptors

Probably meant to be "and it is both".

we'd have to scan all possible fds and close any that we don't want open (normally exec() closes any non-inheritable but we don't exec() for &sub processes.

The parenthesis that opens before "normally" does not seem to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant