Add driver submission address to the autopilot #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
commented
Oct 17, 2024
m-lord-renkse
force-pushed
the
3045/add-submission-address-autopilot
branch
6 times, most recently
from
b52a744 to
42bf53a
Compare
m-lord-renkse
commented
Oct 17, 2024
MartinquaXD
reviewed
Oct 17, 2024
m-lord-renkse
force-pushed
the
3045/add-submission-address-autopilot
branch
11 times, most recently
from
4910d52 to
df34e7e
Compare
sunce86
reviewed
Oct 17, 2024
sunce86
reviewed
Oct 18, 2024
squadgazzz
reviewed
Oct 18, 2024
squadgazzz
reviewed
Oct 18, 2024
m-lord-renkse
force-pushed
the
3045/add-submission-address-autopilot
branch
from
ff9095c to
ef08450
Compare
squadgazzz
reviewed
Dec 12, 2024
squadgazzz
reviewed
Dec 12, 2024
squadgazzz
reviewed
Dec 12, 2024
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
mstrug
approved these changes
Jan 2, 2025
squadgazzz
reviewed
Jan 2, 2025
squadgazzz
reviewed
Jan 2, 2025
squadgazzz
reviewed
Jan 6, 2025
Comment on lines
+551
to
+570
| let drivers_futures = args | ||
| .drivers | ||
| .into_iter() | ||
| .map(|driver| async move { | ||
| infra::Driver::try_new( | ||
| driver.url, | ||
| driver.name.clone(), | ||
| driver.fairness_threshold.map(Into::into), | ||
| driver.submission_account, | ||
| ) | ||
| .await | ||
| .map(Arc::new) | ||
| .expect("failed to load solver configuration") | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| let drivers = futures::future::join_all(drivers_futures) | ||
| .await | ||
| .into_iter() | ||
| .collect(); |
There was a problem hiding this comment.
Suggested change
| let drivers_futures = args | |
| .drivers | |
| .into_iter() | |
| .map(|driver| async move { | |
| infra::Driver::try_new( | |
| driver.url, | |
| driver.name.clone(), | |
| driver.fairness_threshold.map(Into::into), | |
| driver.submission_account, | |
| ) | |
| .await | |
| .map(Arc::new) | |
| .expect("failed to load solver configuration") | |
| }) | |
| .collect::<Vec<_>>(); | |
| let drivers = futures::future::join_all(drivers_futures) | |
| .await | |
| .into_iter() | |
| .collect(); | |
| let drivers_futures = args | |
| .drivers | |
| .into_iter() | |
| .map(|driver| async move { | |
| infra::Driver::try_new( | |
| driver.url, | |
| driver.name.clone(), | |
| driver.fairness_threshold.map(Into::into), | |
| driver.submission_account, | |
| ) | |
| .await | |
| .map(Arc::new) | |
| }) | |
| .collect::<Vec<_>>(); | |
| let drivers = futures::future::try_join_all(drivers_futures) | |
| .await | |
| .expect("failed to load solver configuration"); |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
PR is ready to be merged. Sepolia swap passed successfully. Just a few more nits in infra PR and we can merge them both at the same time. |
squadgazzz
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
LGTM
PR is ready to be merged. Sepolia swap passed successfully.
Just a few more nits in infra PR and we can merge them both at the same time.
Could you link the infra PR explicitly in the description somewhere and also change join_all to try_join_all, as was suggested above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should solve: #3045 and #2780
Changes
/solveto drivers which have been deny listedHow to test
Related Issues
Fixes #3045
Fixes #2780