Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncLimitUsageStorage memory leak in high concurrency situation #46

Open
xiongshilin opened this issue Jan 25, 2019 · 2 comments
Open

Comments

@xiongshilin
Copy link

the call method 'AsyncLimitUsageStorage.addAndGet' occur memory leak, this will create too manay tasks in high concurrency situation, but there is only one thread that executes task to send data to distribute storage, so more and more tasks will be kept in long stock.

@xiongshilin xiongshilin changed the title AsyncLimitUsageStorage memory leak AsyncLimitUsageStorage memory leak in high concurrency situation Jan 25, 2019
@Sytten
Copy link
Contributor

Sytten commented Jan 25, 2019

You should consider using the batched storage in this case then. It will be less accurate, but it's a trade-off. Trying to increase the number of threads to send the data is likely to cause concurrency problems with the current implementation. We should add a note in the readme about this.

@Sytten
Copy link
Contributor

Sytten commented Jan 25, 2019

If you have time to improve it: #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants