Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic configuration of limits. #3

Open
GuiSim opened this issue Apr 21, 2016 · 7 comments
Open

Support dynamic configuration of limits. #3

GuiSim opened this issue Apr 21, 2016 · 7 comments

Comments

@GuiSim
Copy link
Contributor

GuiSim commented Apr 21, 2016

Users will want their limits to be easily modified. You don't want them to be hardcoded at all times!

Support for standard libraries such as Archaius and perhaps an API + Simple UI would be very helpful.

@Sytten
Copy link
Contributor

Sytten commented Nov 8, 2016

I already added archaius in coveo project, if I have the time I will create a more general module for spillway.

@malaporte
Copy link
Contributor

Yeah, but please don't add an hard reference to Archaius in the core project.

@Sytten
Copy link
Contributor

Sytten commented Nov 8, 2016

I was thinking of another module for dynamic configurations using different backends.

@Sytten
Copy link
Contributor

Sytten commented Nov 23, 2016

I think that would be a valuable thing to do in v2.
I have this idea of a configuration provider that would be able to change the limits at runtime over time without recreating a new spillway like we currently do it in our filter.
What do you think @pastjean

@GuiSim
Copy link
Contributor Author

GuiSim commented Dec 1, 2016

Simply using a Supplier<> instead of a fixed value would probably be sufficient.

A simple adapter could then be used to map Supplier.get to ArchaiusProperty.getValue.

@Sytten
Copy link
Contributor

Sytten commented Dec 2, 2016

hum, yes.
Would you suggest to call the supplier each time we check a limit or do an async job and cache the result?

@GuiSim
Copy link
Contributor Author

GuiSim commented Dec 2, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants