Use JSON-style string escaping #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- The current approach to string escaping causes problems if a backslash is included, and also can't handle special characters like tab or CR. Modifications ------------- Serialize string and character constants to the N1QL query using a JSON serializer. Also change some other locations rendering strings to use double quotes for consistency. Results ------- String and character constant expressions now support the full set of characters supported by JSON. Strings now appear on the query wrapped in double quotes instead of single quotes. Fixes #348
jeffrymorris
approved these changes
Aug 9, 2021
|
Thanks Brant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current approach to string escaping causes problems if a backslash
is included, and also can't handle special characters like tab or CR.
Modifications
Serialize string and character constants to the N1QL query using a JSON
serializer.
Also change some other locations rendering strings to use double quotes
for consistency.
Results
String and character constant expressions now support the full set of
characters supported by JSON.
Strings now appear on the query wrapped in double quotes instead of
single quotes.
Fixes #348