LedgerCosmos.GetBip32bytes has pedantic variables and non-idiomatic usages, unnecessary if err != nil, yet could just plainly invoke early returns

[odeke-em]

This code has what looks like C-style coding styles and is quite pedantic to declare the byteslice and the error, then switch between the various callers whose return signatures are ([]byte, error) instead of an immediate return

ledger-cosmos-go/user_app.go

Lines 149 to 169 in e9d4c19

	func (ledger *LedgerCosmos) GetBip32bytes(bip32Path []uint32, hardenCount int) ([]byte, error) {
	var pathBytes []byte
	var err error
	switch ledger.version.Major {
	case 1:
	pathBytes, err = GetBip32bytesv1(bip32Path, 3)
	if err != nil {
	return nil, err
	}
	case 2:
	pathBytes, err = GetBip32bytesv2(bip32Path, 3)
	if err != nil {
	return nil, err
	}
	default:
	return nil, errors.New("App version is not supported")
	}
	return pathBytes, nil
	}

Suggested fix

func (ledger *LedgerCosmos) GetBip32bytes(bip32Path []uint32, hardenCount int) ([]byte, error) { 
 	switch major := ledger.version.Major; major { 
 	case 1: 
 		return GetBip32bytesv1(bip32Path, 3) 
 	case 2: 
 		return GetBip32bytesv2(bip32Path, 3) 
 	default: 
 		return nil, fmt.Errorf("Ledger version: %d is not supported", major) 
 	} 
 } 

/cc @elias-orijtech @julienrbrt

[jleni]

Cosmos app v1 support will be dropped, so most of this code can be completely removed