-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polytone: migrate to CosmWasm v2
#220
Comments
v2
v2
Only one way to find out. Maybe @Reecepbcups could grace us with the magic of
Would be open to other suggestions for how to improve Polytone @CyberHoward. |
We have a WIP integration for polytone to ICT natively: strangelove-ventures/interchaintest#1215 We have planed to re-allocate some engineering time to this again after we complete some more wormhole work Integration test will be super easy to build off that base once we have it configured (plus Spawn integration) |
Personally my main concern with Polytone is its vulnerability to a DOS attack by simply creating packet execution loops, as outlined by the Oak Audit (see screenshot) The way I'd like to see this mitigated is by adding the ability to use an optional whitelist for note senders (address and/or code-id based). That way protocols can deploy their own version of Polytone and configure it to ensure that only its own contracts can use that polytone channel. Thoughts? |
Description
CosmWasm v2 has been slowly gaining adoption throughout the ecosystem. As critical infrastructure, Polytone should be up-to-date with this latest version, allowing devs who are using CW v2 to make use of Polytone.
Issue Scope
While working to upgrade our own contracts we've identified two major changes that should be made to Polytone.
SubMsgResponse
'sdata
field is deprecated.This field is currently used to retrieve and cache execution results before returning them in the
Ack
.Reply
'sPayload
instead of state-caching.A new
Payload
field was added to theSubMsg
which allows developers to pass data to thereply
endpoint without needing to store it to state. Applying this to Polytone would reduce the gas usage and simplify the contract's implementation. It can also be used to cache the execution responses, further reducing gas-costs.Any other issues encountered over the software's life should preferably also be addressed in this update.
Update Rollout
Polytone's canonical deployments are non-migratable. As a result rolling out this update will require a coordinated governance proposal on each deployed chain to migrate the contracts.
Open questions
The text was updated successfully, but these errors were encountered: