-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing validations and implementation in x/circuit #22322
Labels
Comments
akhilkumarpilli
added
C:x/circuit
and removed
needs-triage
Issue that needs to be triaged
labels
Oct 21, 2024
External contributions are welcome 🙏🏾 This issue can be split in 4, those are fairly simple to implements. |
@julienrbrt I would like to work on this issue. |
Feel free to take them. Which ones do you want to start with? |
I will start with first one. |
Hi @julienrbrt , |
Sure, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's the list of missing validations and implementation need to be added in x/circuit module:
Message Type URL Validation Improvement: Add the first / to the message type URL if the user didn’t include it. Ensure the system automatically adds the / when missing. (@kushal0511-not)
Validation for SOME_MSGS: When an account is assigned SOME_MSGS, the limit_type_urls array must not be empty. Add validation to ensure this requirement is met. (@AumThacker)
Validation for ALL_MSGS: When an account is assigned ALL_MSGS, clear the limit type URL collections instead of leaving them populated.
Reset Transaction Feature: The reset transaction feature mentioned in the README is not yet implemented. If msgURL is empty, all previously disabled messages should be re-enabled to reset the message state. Add this functionality to ensure proper resetting behavior.
The text was updated successfully, but these errors were encountered: