[Bug]: server/v2 lacks support for unsafe-skip-upgrades

[kocubinski]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

It is not clear from the help text if this is possible, so I'm assuming it's not, please correct me if I'm wrong.

❯ simd start -h
...
...
      --transport string                                Transport protocol: socket, grpc (default "socket")
      --unsafe-skip-upgrades ints                       Skip a set of upgrade heights to continue the old binary

Compare this to simdv2 output:

❯ simdv2 start -h
...
...
      --server.minimum-gas-prices string                Minimum gas prices to accept for transactions; Any fee in a tx must meet this minimum (e.g. 0.01photino;0.0001stake)
# end of list

Cosmos SDK Version

main

How to reproduce?

No response

[julienrbrt]

Mmh, this is only useful for x/upgrade. In practice, with viper binding, setting a unsafe-skip-upgrades directly in the app.toml or config.toml will make it work with x/upgrade:

cosmos-sdk/x/upgrade/depinject.go

Line 61 in 029d19f

skipUpgrades := cast.ToIntSlice(in.DynamicConfig.Get(server.FlagUnsafeSkipUpgrades))

If we add it to the server/v2 config, then this flag would still be present when the x/upgrade module isn't in the chains (in baseapp world that's the case too and that's meh). Additionally, it would be prefixed by the server name, meaning we'd need to have a case for v1 and v2.

Not sure what is best 🤔