You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduce custom broadcast logic for client/v2.
With the arrival of server/v2 #21069 and the support for other consensus than CometBFT,
client/v2 needs to get updated.
Currently, client/v2 makes use of the client package from the SDK, and it's client.Context.
Those structs and package assume a CometBFT node.
This cannot be assumed anymore when using server/v2:
returnnil, fmt.Errorf("unsupported return type %s; supported types: sync, async", ctx.BroadcastMode)
}
returnres, err
}
There is already work in that direction to abstract client from client/v2.
However, we need to go one step further and make it more extensible to support different broadcast methods / node interface (
Introduce custom broadcast logic for client/v2.
With the arrival of server/v2 #21069 and the support for other consensus than CometBFT,
client/v2 needs to get updated.
Currently, client/v2 makes use of the client package from the SDK, and it's
client.Context
.Those structs and package assume a CometBFT node.
This cannot be assumed anymore when using server/v2:
cosmos-sdk/client/broadcast.go
Lines 23 to 36 in 4666e1d
There is already work in that direction to abstract
client
fromclient/v2
.However, we need to go one step further and make it more extensible to support different broadcast methods / node interface (
cosmos-sdk/client/cometbft.go
Line 12 in 4666e1d
Example usage case: Reecepbcups@49ca35c
The text was updated successfully, but these errors were encountered: