Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/v2: e2e/system tests #20800

Closed
15 tasks done
Tracked by #20439
tac0turtle opened this issue Jun 27, 2024 · 2 comments
Closed
15 tasks done
Tracked by #20439

server/v2: e2e/system tests #20800

tac0turtle opened this issue Jun 27, 2024 · 2 comments
Assignees
@julienrbrt @akhilkumarpilli
Labels
C:server/v2 Issues related to server/v2 T: Tests

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jun 27, 2024 •
edited by akhilkumarpilli
Loading

Evaluate migrating e2e tests to system tests so we can use app v1 and v2 without needing to do hacks with build flags to attempt to make it work.

Goals:

  • Find an e2e test from tests/e2e that looks like a system test.
  • Rewrite it as a system test and verify it runs with v1 and v2 (CI does that)
  • Delete the old e2e test.

To check:
Remember: only migrate the applicable ones.

To Add
@tac0turtle tac0turtle mentioned this issue Jun 27, 2024
Open
21 tasks
@tac0turtle tac0turtle changed the title tests/e2e server/v2: e2e tests Jun 27, 2024
@tac0turtle tac0turtle added C:server/v2 Issues related to server/v2 C:core/testing T: Tests and removed C:core/testing labels Jun 27, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 27, 2024
@tac0turtle tac0turtle removed the needs-triage Issue that needs to be triaged label Jun 28, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Sep 3, 2024 •
edited
Loading

I think we are going for a migration to system tests when applicable here right?
re-read the issue, missed a word 🤦🏾

@julienrbrt julienrbrt changed the title server/v2: e2e tests server/v2: e2e/system tests Sep 3, 2024
@julienrbrt julienrbrt mentioned this issue Sep 4, 2024
Merged
12 tasks
@coderabbitai coderabbitai bot mentioned this issue Sep 9, 2024
Merged
12 tasks
@mergify mergify bot mentioned this issue Sep 26, 2024
Merged
12 tasks
@julienrbrt julienrbrt mentioned this issue Oct 1, 2024
Closed
19 tasks
@tac0turtle
Copy link
Member Author

closing this as #22358 has to do with e2e and integration tests. Nice job team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

@akhilkumarpilli akhilkumarpilli

Labels
C:server/v2 Issues related to server/v2 T: Tests
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tac0turtle @julienrbrt @akhilkumarpilli