Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fwupd-refresh.timer by default on IoT, CoreOS & Server editions #1512

Closed
travier opened this issue Jun 21, 2023 · 21 comments · Fixed by coreos/fedora-coreos-config#2562
Assignees

Comments

@travier
Copy link
Member

travier commented Jun 21, 2023

Important links

Describe the enhancement

fwupd-refresh systemd service unit & timer are designed to regularly refresh the fwupd metadata and update the MOTD when new firmware updates can be applied on a system.

We should submit a Fedora Change for F39 to enable fwupd-refresh.timer by default on IoT, CoreOS & Server editions so that users get reminded about firmware updates.

On desktops, firmware updates are generally coordinated by graphical applications such as GNOME Software or Plasma Discover.

System details

N/A

Additional information

See related discussion in #1478


Note that we have to submit the change before Tue 2023-06-27 (System Wide Changes) or Tue 2023-07-18 (Self Contained Changes): https://fedorapeople.org/groups/schedule/f-39/f-39-key-tasks.html


Steps to make this change:

@resdigita
Copy link

resdigita commented Jun 23, 2023

Just detected this by chance. Seems reasonable to me to include it into Server as well. Unfortunately, I'm not familiar with the current state. I guess, currently, does happen nothing at all? And wouldn't it be helpful to include an email as well (in addition to MOTD)?

([email protected] - Server WG)

@travier
Copy link
Member Author

travier commented Jun 23, 2023

Just detected this by chance.

Note that this issue is for tracking on our side. We'll submit a proper Fedora Change request that will be announced on fedora-devel.

Seems reasonable to me to include it into Server as well. Unfortunately, I'm not familiar with the current state. I guess, currently, does happen nothing at all? And wouldn't it be helpful to include an email as well (in addition to MOTD)?

Nothing happens right now without this timer. If you want an email, then you'd likely have to write the code to do it as we're unlikely do it for Fedora CoreOS.

@travier travier added the jira for syncing to jira label Jun 26, 2023
@ravanelli
Copy link
Member

The Fedora change page was created: https://fedoraproject.org/wiki/Changes/EnableFwupdRefreshByDefault
I asked for review/inputs on it in the FCOs meeting today.

@dustymabe
Copy link
Member

The change page text LGTM

@travier
Copy link
Member Author

travier commented Jun 30, 2023

Suggestion for the "Detailed Description":

Firmware for hardware devices can have bugs and firmware updates generally help address those. Firmware updates might however need manual interaction, a reboot or device unplug/re-plug so we can not enable firmware update by default.

This change thus only enable notifying about new firmware updates, not installing them.

With this change, Fedora installations will contact the Linux Vendor Firmware Service (LVFS, https://fwupd.org/) to get the updated metadata but will not send any information about the hardware without user interaction.

See the LVFS privacy policy at https://lvfs.readthedocs.io/en/latest/privacy.html.

@travier
Copy link
Member Author

travier commented Jun 30, 2023

Can you start reaching out to the IoT & Server WG?

@travier
Copy link
Member Author

travier commented Jun 30, 2023

@hughsie Could you confirm what I've written in #1512 (comment) about privacy implications? Thanks

@hughsie
Copy link

hughsie commented Jun 30, 2023

@travier that's completely correct, thanks. Downloading the metadata is from the CDN and there are no logs on that at all -- the only time we'd contact the LVFS server directly is to download the firmware payload blob itself (we have to check the country of the requester for ITAR/EAR legal reasons) and then after that the user can optionally upload a success/failure report.

A more accurate version might be to change:

With this change, Fedora installations will contact the Linux Vendor Firmware Service CDN (LVFS, https://cdn.fwupd.org/) to get the updated metadata..

@ravanelli
Copy link
Member

Open issues for IoT & Server working groups:

@travier
Copy link
Member Author

travier commented Jul 17, 2023

I've update the Wiki page to link to the discussions in the various places.

@travier
Copy link
Member Author

travier commented Jul 17, 2023

@ravanelli
Copy link
Member

Request change submitted.
Status: ChangeReadyForWrangler

@travier
Copy link
Member Author

travier commented Jul 18, 2023

I've updated the Change now that the Server WG has answered

@travier
Copy link
Member Author

travier commented Aug 11, 2023

FESCo discussion: https://pagure.io/fesco/issue/3054

@travier
Copy link
Member Author

travier commented Aug 21, 2023

This has been accepted by FESCo in https://pagure.io/fesco/issue/3054 so we can do the change now.

@travier
Copy link
Member Author

travier commented Aug 23, 2023

PR in fedora-release RPM, mostly for Server & IoT as they do not "preset-all" and thus need a manual unit enablement: https://src.fedoraproject.org/rpms/fedora-release/pull-request/279

@travier
Copy link
Member Author

travier commented Aug 23, 2023

Change for FCOS: coreos/fedora-coreos-config#2562

@dustymabe dustymabe added status/pending-next-release Fixed upstream. Waiting on a next release. F39 labels Sep 20, 2023
@dustymabe dustymabe changed the title Fedora Change: Enable fwupd-refresh.timer by default on IoT, CoreOS & Server editions Enable fwupd-refresh.timer by default on IoT, CoreOS & Server editions Sep 20, 2023
@dustymabe
Copy link
Member

The fix for this went into next stream release 39.20230916.1.1. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. and removed status/pending-next-release Fixed upstream. Waiting on a next release. labels Sep 20, 2023
@dustymabe
Copy link
Member

The fix for this went into testing stream release 39.20231101.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. labels Nov 7, 2023
@dustymabe
Copy link
Member

The fix for this went into stable stream release 39.20231101.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants