add check for preferred format of Content Type (DON'T MERGE YET) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the "make" process was not done yet to check the changes - I'm on a laptop without the toolchain now. |
thomas-fossati
approved these changes
Jan 30, 2025
| ## Preferred Format for the Content Type Field {#preferred-format} | ||
|
|
||
| This section defines the preferred string format for including a requested Content Type into the CoAP Content-Formats registry. | ||
| During the review procedure, the Designated Expert(s) or IANA may rewrite a requested Content Type to this preferred string format prior to approval. |
There was a problem hiding this comment.
Maybe
"During the review process, the Designated Expert(s) or IANA may rewrite a requested Content Type into this preferred string format before approval."
I ran |
|
Question: Is it worth addressing #23 in this PR too? |
Signed-off-by: Thomas Fossati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #22
Note: for clarity this shows the diff w.r.t. Marco's recent PR.
Before merging, this needs to be updated to go into the main branch!