.github/workflows/action-test-smoke: Add a step to verify the jeager #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- scripts/setup-jeager-and-otel.sh: Language not supported
- scripts/verify-jaeger-traces.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/action-test-smoke.yml:63
- The spelling of 'Jeager' should be corrected to 'Jaeger' in the error message.
echo "Operation '$op' not found in Jaeger!"
Add a GitHub Action step to verify that Jeager actually receives the expected emitted traces, rather than just hoping they made it. It uses Jeager API to fetch the traces, and note that the limit=0 so that we can get all the operations. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]> scripts/verify-jaeger-traces: Add a script to verify jeager traces Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]> rename scripts/setup-otel.sh -> scripts/setup-jeager-and-otel.sh Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
jeager-integration-test
branch
from
3914cd1 to
f0c0a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub Action step to verify that Jeager actually receives the expected emitted traces, rather than just hoping they made it.
It uses Jeager API to fetch the traces, and note that the limit=0 so that we can get all the operations.
This is to prevent #787 from happening without getting notices.