Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics endpoint #543

Open
fitzthum opened this issue Oct 21, 2024 · 1 comment
Open

Add metrics endpoint #543

fitzthum opened this issue Oct 21, 2024 · 1 comment

Comments

@fitzthum
Copy link
Member

Currently the only way to figure out the status of Trustee is to look at the logs. We should add a more sophisticated metrics infrastructure that can be connected into third-party systems.

@fitzthum fitzthum changed the title RFC: Add metrics endpoint Add metrics endpoint Oct 21, 2024
@fitzthum fitzthum moved this to We have a requirement in Trustee Roadmap Oct 21, 2024
@fitzthum fitzthum closed this as completed by moving to We have a requirement in Trustee Roadmap Oct 21, 2024
@fitzthum fitzthum reopened this Oct 21, 2024
@mkulke
Copy link
Contributor

mkulke commented Oct 22, 2024

Note that while prometheus support is a good idea, it will not supplement logs. metrics are about aggregate values (think: number of successful tdx verifications per minute), you shouldn't/cannot debug individual transactions with it (because of restrictions on the cardinality of metrics).

the closest to a supplement logs today are opentelemetry traces. sadly, this is still a bit rough for rust webservices today. but embracing structured logs via tracing is a step in the right direction. e.g. there should be correlation ids to debug logical transactions (like an RCAR ceremony).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: We have a requirement
Development

No branches or pull requests

2 participants