Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate docker registry #1016

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Deprecate docker registry #1016

wants to merge 9 commits into from

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Dec 10, 2024 •
edited
Loading

fixes #942

Description

This aims to start the process of removing the /registry endpoint. It:

  • disables the registry endpoint by default
  • adds deprecation headers to all the endpoints under /registry
  • target deprecation date March 17, 2025

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 5ee3524
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67804943d3a145000835bb09

@soapy1 soapy1 force-pushed the deprecate-registry branch 4 times, most recently from c7e874f to ee225a1 Compare December 10, 2024 05:38
@soapy1 soapy1 marked this pull request as ready for review December 10, 2024 16:07
@soapy1 soapy1 requested a review from peytondmurray December 10, 2024 16:07
@soapy1 soapy1 force-pushed the deprecate-registry branch 2 times, most recently from 54f39e5 to 8431910 Compare December 10, 2024 18:41
@soapy1 soapy1 marked this pull request as draft December 10, 2024 20:17
@soapy1 soapy1 marked this pull request as ready for review December 10, 2024 21:53
peytondmurray
peytondmurray approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

conda-store-server/conda_store_server/_internal/server/views/registry.py Outdated Show resolved Hide resolved
@soapy1 soapy1 mentioned this pull request Dec 16, 2024
Merged
3 tasks
@soapy1 soapy1 force-pushed the deprecate-registry branch from 338664d to d0c94c7 Compare December 16, 2024 22:57
@soapy1 soapy1 requested a review from peytondmurray December 16, 2024 23:00
@soapy1 soapy1 force-pushed the deprecate-registry branch from e386a62 to 24b74fe Compare December 17, 2024 18:20
@soapy1 soapy1 requested a review from trallard December 17, 2024 18:22
@soapy1 soapy1 force-pushed the deprecate-registry branch from f75b803 to d52b998 Compare December 17, 2024 21:15
trallard
trallard requested changes Jan 6, 2025
View reviewed changes
conda-store-server/conda_store_server/_internal/server/views/api.py Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/artifacts.md Show resolved Hide resolved
docusaurus-docs/conda-store/references/configuration-options.md Outdated
Comment on lines 219 to 222
#### Deprecated configuration options for `conda_store_server._internal.app.CondaStore`

`CondaStore.serialize_builds` no longer has any effect

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is a H4 instead of a H3 like the rest of the configuration options? Being an H4 means this does not show in the in-page TOC like the rest of the config options.

Also, line 509 has ### (deprecated) conda_store_server.registry.ContainerRegistry`, so we have inconsistent formatting; we should stick to one throughout.

Copy link
Contributor Author

@soapy1 soapy1 Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 bits were intentional.

Deprecated configuration options for conda_store_server._internal.app.CondaStore is H3 to denote that this part of the docs belongs to the parent topic conda_store_server._internal.app.CondaStore (which is H2). These subsections denote configuration options that belong to a particular configuration class have been deprecated. So, like the heading at 219 is all the config options that belong to c.CondaStore that are deprecated. The heading at 487 is all the config options that belong to c.CondaStoreServer that are deprecated, etc.

Line 509 is different, it denotes that a whole configuration class has been deprecated.

docusaurus-docs/conda-store/references/configuration-options.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/references/configuration-options.md Show resolved Hide resolved
@soapy1 soapy1 force-pushed the deprecate-registry branch 2 times, most recently from f025488 to 025b0e6 Compare January 6, 2025 16:27
@soapy1 soapy1 requested a review from trallard January 6, 2025 16:28
@soapy1 soapy1 force-pushed the deprecate-registry branch from 2a46af4 to d3f59cc Compare January 6, 2025 16:31
peytondmurray
peytondmurray approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good - thanks for making that deprecation decorator.

conda-store-server/conda_store_server/_internal/server/views/api.py Outdated Show resolved Hide resolved
@soapy1 soapy1 force-pushed the deprecate-registry branch from 1e163e0 to 24ea2f7 Compare January 9, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

@trallard trallard Awaiting requested review from trallard

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs: review 👀 type: deprecations ⛔️
Projects
conda-store 🐍
Status: In review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate docker registry
3 participants
@soapy1 @peytondmurray @trallard