Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show grid resize handles on top of scene labels #6486

Closed
wants to merge 3 commits into from

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Oct 7, 2024

Problem:

The grid resize handles are shown on top of the scene label.

image

Fix:

Move the handles north of the scene label if the grid is also a scene.

Screenshot 2024-10-07 at 14 04 32

Fixes #6485

@ruggi ruggi marked this pull request as ready for review October 7, 2024 12:07
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Try me

Copy link

relativeci bot commented Oct 7, 2024

#14623 Bundle Size — 57.76MiB (~+0.01%).

74a7c44(current) vs 916e8b9 master#14617(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14623
     Baseline
#14617
Regression  Initial JS 40.76MiB(~+0.01%) 40.76MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.96% 18.48%
No change  Chunks 21 21
No change  Assets 23 23
No change  Modules 4112 4112
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.4% 27.4%
No change  Packages 475 475
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14623
     Baseline
#14617
Regression  JS 57.75MiB (~+0.01%) 57.75MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/grid-resizing-scene-labelProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi
Copy link
Contributor Author

ruggi commented Oct 8, 2024

moving it to draft while we decide on the approach here

@ruggi ruggi marked this pull request as draft October 8, 2024 12:26
@ruggi
Copy link
Contributor Author

ruggi commented Oct 9, 2024

this has been superseded by parallel work, closing

@ruggi ruggi closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't display grid resize handles on top of scene labels
4 participants