Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): fix warning about giving a ref to a function component #6479

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Oct 6, 2024

Problem:
Today we have a constant warning about giving a ref to a function component inside DesignPanelRoot

image

Fix:
Wrap the component in forwardRef to avoid this warning.
This will also greatly reduce our tests logs.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Try me

Copy link

relativeci bot commented Oct 6, 2024

#14601 Bundle Size — 57.82MiB (~+0.01%).

cea25c5(current) vs 916e8b9 master#14593(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14601
     Baseline
#14593
Regression  Initial JS 40.76MiB(~+0.01%) 40.76MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.01% 18.85%
No change  Chunks 23 23
No change  Assets 25 25
No change  Modules 4115 4115
No change  Duplicate Modules 216 216
No change  Duplicate Code 27.48% 27.48%
No change  Packages 475 475
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14601
     Baseline
#14593
Regression  JS 57.82MiB (~+0.01%) 57.82MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/forward-ref-warningProject dashboard


Generated by RelativeCIDocumentationReport issue

@liady liady merged commit 00b93bd into master Oct 7, 2024
16 checks passed
@liady liady deleted the fix/forward-ref-warning branch October 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants