Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call fixElementsToRerender last in collectElementsToRerender #6471

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Oct 4, 2024

Problem

fixElementsToRerender needs to be called last in collectElementsToRerender, since it needs to store all elements paths passed to it in lastElementsToRerender. Otherwise, any subsequent elements paths that are calculated based on the return value won't be cleared from the metadata

Fix

Re-order the contents of collectElementsToRerender so that fixElementsToRerender can store all element paths that collectElementsToRerender collected

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Try me

Copy link

relativeci bot commented Oct 4, 2024

#14569 Bundle Size — 57.79MiB (~-0.01%).

89a9f9c(current) vs 916e8b9 master#14568(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#14569
     Baseline
#14568
Improvement  Initial JS 40.74MiB(~-0.01%) 40.74MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.04% 18.02%
No change  Chunks 23 23
No change  Assets 25 25
No change  Modules 4108 4108
No change  Duplicate Modules 214 214
No change  Duplicate Code 27.47% 27.47%
No change  Packages 475 475
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#14569
     Baseline
#14568
Improvement  JS 57.78MiB (~-0.01%) 57.78MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/fix-elements-to-rerender-cal...Project dashboard


Generated by RelativeCIDocumentationReport issue

@bkrmendy bkrmendy marked this pull request as ready for review October 4, 2024 09:10
@bkrmendy bkrmendy merged commit e0b99ea into master Oct 4, 2024
18 checks passed
@bkrmendy bkrmendy deleted the fix/fix-elements-to-rerender-calling-order branch October 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants