Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for Feedback Milestone 3 #252 #263

Merged
merged 8 commits into from
Apr 3, 2020
Merged

Improvements for Feedback Milestone 3 #252 #263

merged 8 commits into from
Apr 3, 2020

Conversation

MistereoSC
Copy link
Contributor

@MistereoSC MistereoSC commented Apr 2, 2020 •
edited by DevPhilB
Loading

Changes

  • Register Page now directs to login after registration
  • CMS Nav Menu now highlights selected tab
  • Added Loading Spinners to Register, Login and CMS pages
  • Updated Loading and Register pages to use Bootstrap
  • Updated Board List and User List within the CMS page to use Bootstrap
  • Added a (temporary) logout page at /logout
  • Minor localization improvements

@MistereoSC MistereoSC self-assigned this Apr 2, 2020
@DevPhilB DevPhilB added this to the Milestone IV milestone Apr 2, 2020
@DevPhilB DevPhilB linked an issue Apr 2, 2020 that may be closed by this pull request
Feedback: Milestone 3 #252
Open
DevPhilB
DevPhilB suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@DevPhilB DevPhilB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Register Page now directs to login after registration
  • CMS Nav Menu now highlights selected tab
  • Added Loading Spinners to Register, Login and CMS pages -> didn't see any spinner, please add a screenshot
  • Updated Loading and Register pages to use Bootstrap
  • Updated Board List and User List within the CMS page to use Bootstrap
  • Added a (temporary) logout page at /logout -> there is no logout page (only a redirect with /logout to /login)
  • Minor localization improvements -> You should fix the tables and their search bar, it's too obvious:

CMS-Translation-Issues

  • Created -> Erstelldatum (you have chosen: Erstellt)
  • Email -> E-Mail oder E-Mail-Adresse
  • Username -> Benutzername (you have chosen: Nutzername)
  • Delete -> Löschen

CMS-Translation-Issues-2

  • Created -> Erstelldatum (you have chosen: Erstellt)
  • boardName-> Name ('Board' follows from the context)
  • Delete -> Löschen

@MistereoSC
Copy link
Contributor Author

  • Without a lot of Data to load, loading spinners are barely visible, but they are present
    LoadingSpinners

  • Logout page just is a blank page that redirects you back to login. But it also deletes local storage, and sends a logout request to the serve

  • Table headers have been translated. Unfortunately, since they are stored within the 'fields' variable, they only update on page refresh when changing language

@MistereoSC MistereoSC requested a review from DevPhilB April 3, 2020 13:29
@DevPhilB DevPhilB merged commit 8a476f9 into development Apr 3, 2020
@MistereoSC MistereoSC deleted the hotfix/feedback-milestone-3 branch April 15, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevPhilB DevPhilB DevPhilB approved these changes

@Simon-Deuring Simon-Deuring Awaiting requested review from Simon-Deuring

Assignees

@MistereoSC MistereoSC

Labels
None yet
Milestone
Milestone IV
Development

Successfully merging this pull request may close these issues.

Feedback: Milestone 3
2 participants
@MistereoSC @DevPhilB