Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change urlpatterns to match Django1.10 #117

Open
noamgal opened this issue Jun 15, 2016 · 10 comments
Open

Change urlpatterns to match Django1.10 #117

noamgal opened this issue Jun 15, 2016 · 10 comments
Assignees

Comments

@noamgal
Copy link

noamgal commented Jun 15, 2016

django.conf.urls.patterns() will be removed in Django1.10.
https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-1-10

There are 2 pull requests to fix that:
#116 (mine , very defensively for django version)
and #115

@iankpconcentricsky - please approve one of them

Thanks

@DarthLabonne
Copy link

+1

@DarthLabonne
Copy link

About your patch, it should be:

main_ver = int(django_version[0])
secondary_ver = int(django_version[1])

else, you get:

TypeError: int() argument must be a string or a number, not 'list'

@Tsangares
Copy link

@iankpconcentricsky I second that pull request

@noamgal
Copy link
Author

noamgal commented Aug 23, 2016

@iankpconcentricsky @Tsangares so, what is the status of this? isn't that urgent for django 1.10?

@Tsangares
Copy link

@noamgal Yes, it looks like there is another pull request #118. I could not get this django-tastypie-swagger to work sadly. Using pull #118, and #116, did not completely solve my issues. I do admit, I did not try very hard. But I was not eager to go debug someone else's code, I just started writing my own documentation because my api is small.

@joshkehn
Copy link
Contributor

@noamgal Will try and find time to review this PR this week.

@joshkehn joshkehn self-assigned this Aug 23, 2016
@joshkehn
Copy link
Contributor

Linking #118 that covers this as well.

@andrijan
Copy link

Any news on this?

@pg1671
Copy link

pg1671 commented Nov 30, 2016

+1

@AlSayedGamal
Copy link

PR #121 should solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants