Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factor dataset (table) getters #74

Open
jonkeane opened this issue Sep 19, 2022 · 0 comments
Open

Re-factor dataset (table) getters #74

jonkeane opened this issue Sep 19, 2022 · 0 comments

Comments

@jonkeane
Copy link
Contributor

We have dataset.get_table_dataset() which then calls dataset specification getters (get_raw_tpc_dataset_spec and get_csv_dataset_sped), but this probably isn't quite right. Would it be possible to simplify these so that they all get the dataset directly?

These also are a bit funny because in principle they should be methods on the Table class (but they require information about the dataset those tables belong to in order to work, so maybe we need to do some duplications of attributes to make that not be necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant