Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a post_package_info hook to check that all libs listed in system_libs are lower case if host os is Windows #479

Open
SpaceIm opened this issue Jan 22, 2023 · 5 comments · May be fixed by #480
Open

Add a post_package_info hook to check that all libs listed in system_libs are lower case if host os is Windows #479

SpaceIm opened this issue Jan 22, 2023 · 5 comments · May be fixed by #480

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 22, 2023

MinGW on Linux doesn't support upper case system libs, but Visual Studio & MinGW on Windows don't care. So the robust approach is to always list system libs full lower case when host os is Windows.
@SpaceIm SpaceIm changed the title Add a hook to check that all libs listed in system_libs are lower case if host os is Windows Add a post_package_info hook to check that all libs listed in system_libs are lower case if host os is Windows Jan 22, 2023
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 22, 2023

An issue which could be avoided with this hook: conan-io/conan-center-index#15405

@rilian-la-te
Copy link

@SpaceIm how I can workaround this in my CMakeLists.txt?

@SpaceIm SpaceIm linked a pull request Jan 22, 2023 that will close this issue
Open
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 22, 2023

You can't, recipe must be fixed.

@AbrilRBS
Copy link
Member

@rilian-la-te Hi! As @SpaceIm points out, the point of this kind of hooks is to guard against introducing bugs/unexpected issues, so being able to work around them would be counterproductive.
There's the possibility of allowing specific recipes to be ignored by the hooks if the need arises (Which if you check the PRs in this repo, is somewhat common!), but we would need to know why it would be needed :)

@rilian-la-te
Copy link

@RubenRBS I want to workaround a buggy recipe) For now my best solution is using sed after conan install)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rilian-la-te @AbrilRBS @SpaceIm