-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[conan-center-index] Checks for semantic errors #182
Comments
Seems like #177 helps close this |
It also appears the CCI wiki it a bit out of date. |
What parts of the wiki are outdated? |
It's duplicated with #177 |
"Error-Knowledge-Base" ends at # 37 but there's 44 with the addition of #177 https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Probably only 40 is missing Line 45 in b192c59
|
@uilianries @prince-chrismc could you give me some additional background, e.g. why does |
This comment is why I brought it up over here. lots of discussion around it in the PR |
I've been talking with @uilianries about that.
you will probably be unable to use the library with cpstd=None at all. moreover, you may encounter runtime issues in the cases like:
the cases like above might be rare and some corner cases, but it's still incorrect to mark c++11 packages with c++98 package id (which we're doing for some packages in conan center right now). |
It would be nice if there was the addition of two new checks, thought I am not sure where they would go in the hooks.
self.requires.add
which should not have the last add portiontools.check_min_cppstd
should always have a precedingif self.settings.get_safe("compiler.cppstd"):
I am sure there are other "bad practices" which could be added but these two are very common looking at older recipes, next time they get update it will be more complete.
The text was updated successfully, but these errors were encountered: