test for integrity remove #17628
Open
test for integrity remove #17628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
reviewed
Jan 26, 2025
Comment on lines
+45
to
+53
| t.run("create . --name pkg1 --version 1.0") | ||
| t.run("create . --name pkg2 --version=2.0") | ||
| layout = t.exported_layout() | ||
| manifest = os.path.join(layout.export(), "conanmanifest.txt") | ||
| os.remove(manifest) | ||
|
|
||
| t.run("cache check-integrity *", assert_error=True) | ||
| assert "pkg1/1.0: Integrity checked: ok" in t.out | ||
| assert "ERROR: pkg2/2.0#4d670581ccb765839f2239cc8dff8fbd: Manifest missing" in t.out |
There was a problem hiding this comment.
I'd like for this to remove pkg1's manifest, to show that we still iterate the rest of them even after the first error
Comment on lines
+64
to
+73
| t.run("create . --name pkg2 --version=2.0") | ||
| layout = t.created_layout() | ||
| manifest = os.path.join(layout.package(), "conanmanifest.txt") | ||
| os.remove(manifest) | ||
|
|
||
| t.run("cache check-integrity *", assert_error=True) | ||
| assert "pkg1/1.0: Integrity checked: ok" in t.out | ||
| assert "ERROR: pkg2/2.0#4d670581ccb765839f2239cc8dff8fbd" \ | ||
| ":da39a3ee5e6b4b0d3255bfef95601890afd80709" \ | ||
| "#0ba8627bd47edc3a501e8f0eb9a79e5e: Manifest missing" in t.out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
Close #17622