Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code of CONAN_PIP_INSTALL commands are not checked #565

Open
chausner-audeering opened this issue May 14, 2021 · 0 comments
Open

Exit code of CONAN_PIP_INSTALL commands are not checked #565

chausner-audeering opened this issue May 14, 2021 · 0 comments

Comments

@chausner-audeering
Copy link

Description of Problem, Request, or Question

When pip packages are specified in CONAN_PIP_INSTALL and the pip installation fails for some reason (e.g. because the package cannot be found or the pip remote is not reachable), cpt continues with the build and in my case fails at a later stage due to the missing packages.

I suggest to add a check for the exit code of the pip install and abort the build early if the package installation was not successful. This makes it easier to find out why builds fail when the pip installation is unsuccessful.

Environment Details

  • Conan Package Tools Version: 0.35.1
  • Operating System: Linux
  • Operation System Version: Ubuntu 18.04
  • Compiler+version: gcc-7
  • Docker image: conanio/gcc7
  • Conan version: conan 1.35.1
  • Python version: python 3.6.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant