Fix profile issiues #582 and #556 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry, but the log file of the ci is not very helpful. Is the ci working? |
uilianries
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
@SamsonBox thank you for your contribution. Your hotfix looks correct
|
@uilianries Sorry I made a mistake. The #556 was not fixed. It is the #440 which got fixed. Sorry for that. |
|
@SamsonBox No problem at all, thank you for fixing and reporting. I'll update these issues status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Bugfix):
This fix resolves the issiues #582 and #556
To Fix #582 the base_profile_build is handled like the normal build_profile without the settings override
To Fix #556 the installation of the settings is handled before the profiles are generated and written to the tmp folder