-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptopp: Add use_openmp option #25419
base: master
Are you sure you want to change the base?
Conversation
This option is present in Crypto++'s CMakeList.txt but was not exposed in the conanfile.py. Adding exposure for it.
This comment has been minimized.
This comment has been minimized.
No idea why ci fails. Asked for access in the access task because i thought that would allow me to read the CI logs, but even though I saw a task saying I supposedly have access now, I still can't read the CI log. Seems it's a pretty complicated process to try and contribute to conan. Not sure how to proceed. |
Thanks! You will also need to list OpenMP in the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 8 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
This option is present in Crypto++'s CMakeList.txt but was not exposed in the conanfile.py. Adding exposure for it.
Summary
Changes to recipe: cryptopp/*
Motivation
This is an option that allows enabling OpenMP for the cryptographic algorithms in Crypto++. It will speed up some and slow down other algorithms.
Details
Default is
False
since it can have a negative performance impact on some algorithms. But it will speed up others, so it should be up to the caller.