Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on csv package #26

Open
harendra-kumar opened this issue Jan 25, 2022 · 2 comments · May be fixed by #32
Open

Remove dependency on csv package #26

harendra-kumar opened this issue Jan 25, 2022 · 2 comments · May be fixed by #32
Assignees
@adithyaov

Comments

@harendra-kumar
Copy link
Member

csv is pretty simple. We can use something similar to https://github.com/composewell/streamly-examples/blob/master/examples/CSVParser.hs or just replace parsec with streamly parser in the csv package, it is trivial parsing. In fact, we can add a Streamly.CSV module in streamly itself, to load and dump the csv format.
@adithyaov
Copy link
Member

See #32

@adithyaov adithyaov linked a pull request Jan 27, 2022 that will close this issue
Replace functionality of csv with streamly #32
Open
@adithyaov
Copy link
Member

We can just leave this be I believe. I do not want to depend on any internal modules of streamly, which I believe I'll need to depend on to make a clean solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adithyaov adithyaov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace functionality of csv with streamly composewell/bench-show
2 participants
@harendra-kumar @adithyaov