-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CtWanted and GHC 8.2.2 in ConCat.BuildDictionary #41
Comments
This is a new field in I think @osa1 had this added already in his ghc-8.2 patch. Will look this up. |
Terrific. IIRC, the difficulty with @osa1's old ghc-8.2 patch was that it did not also keep the plugin working under 8.0.2, to allow testing and transition. Hopefully we can now get fixes re-added while keeping 8.0.2 working. Sorry for the hassle! |
You have to change nonC = mkNonCanonical $
CtWanted { ctev_pred = predTy
, ctev_dest = EvVarDest evar
#if MIN_VERSION_GLASGOW_HASKELL(8,2,0,0)
, ctev_nosh = WOnly
#endif
, ctev_loc = loc } I'm not sure (and it seem @osa1 was neither) about what value to use there. Possible choices are |
No, I think @osa1's patch actually was compiling for all of 8.0, 8.2, and 8.4. I think he was just too perfectionistic and didn't want to submit it as a PR while 8.2 and 8.4 was clearly still broken. And then in the meantime, |
Oh! I'm really sorry we diverged. :( And of course we'll want to be on 8.4 soon. I'm especially eager to get working on 8.6, since that version will allow plugins not to trigger unnecessary recompilations. I don't have a lot of experience with collaborative programming. If you have advice for me about how not to cause the repo to diverge during our work together, I'm all ears. |
Well, to a large extent it was us being slow, so our fault. But one thing that would help a bit is to make sure that |
Sounds sensible. Thanks! |
Do you want me to submit the |
I'll do it.I'll do it, but I'd appreciate your checking into whether to use |
Compile-time warning:
Try a simple example anyway:
I don't know why GHC is mis-reporting the file name for
ConCat.BuildDictionary
The text was updated successfully, but these errors were encountered: