Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: account and authentication endpoints #48

Closed
ChurchOfTheSubgenius opened this issue Mar 25, 2024 · 5 comments
Closed

router: account and authentication endpoints #48

ChurchOfTheSubgenius opened this issue Mar 25, 2024 · 5 comments
Assignees
Milestone

Comments

@ChurchOfTheSubgenius
Copy link
Member

To start working towards meeting API parity with the golang server, we should start out by implementing the account and authentication API endpoints. Please refer to the account table in issue #43.

@avdb13
Copy link
Collaborator

avdb13 commented Mar 25, 2024

Account routes should probably pay attention to matrix-org/matrix-spec-proposals#2828 so that future compatibility with Conduit (which I'm pretty sure already performs username validity checks) isn't broken.

On the other hand, I wonder whether the password reset route should only require the old password. The API just falls back on UIAA which requires a user identifier but /whoami can translate the access token to a username whenever necessary.
Refer: https://docs.ruma.io/ruma_client_api/uiaa/enum.UserIdentifier.html

@erlend-sh
Copy link
Contributor

erlend-sh commented Mar 25, 2024

Future compatibility with Conduit is a non-concern at this stage. We build to be compatible with Synapse first, and make changes in the future if necessary for compatibility with Conduit.

Trying to preempt future requirements now will require much more time and work as opposed to being adaptable to changing requirements as they become practical reality.

avdb13 said:

Sorry for the confusion here, this is not Conduit-specific but Conduit is already adhering to this MSC as it's still working towards a stable release.
The check can eventually be removed in the future and is adding little overhead, since user IDs are such a core concept this does seem like part of Commune's concern.

👌

@ChurchOfTheSubgenius
Copy link
Member Author

For now, let's do what the golang code does. Once the API parity list on #43 reaches fully green, then we can think of enhancements and optimizations.

@avdb13
Copy link
Collaborator

avdb13 commented Mar 29, 2024

#51 dealed with the account endpoints.

@avdb13 avdb13 closed this as completed Mar 29, 2024
@avdb13
Copy link
Collaborator

avdb13 commented Mar 30, 2024

Closed in favor of #53.

Will update the OP eventually to reflect the new location of the endpoints.

@avdb13 avdb13 changed the title Account and authentication endpoints router: account and authentication endpoints Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants