You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for this great tool. I'd like to submit a feature request to expand the pick and omit functionality when making a custom build. Specifically:
Add the ability to pick only certain US states (e.g., only pick holiday information for US + TX, and omit the other state-specific holidays).
Add the ability to omit the holiday names in other languages (or to pick certain languages).
I use this library to automatically display custom support / CX hours during my company's holidays. Even with the custom build (holidays2json --pick US --min), it adds 350KiB (80KiB zipped) to our bundle, which is quite a bit (it's the second-largest bundle in our app).
Thank you for your consideration.
- Ilya
The text was updated successfully, but these errors were encountered:
Edit: I wrote a script to accomplish the above that omits all languages except English and removes all US state holidays except TX's, but the bundle is still quite large at 70KiB zipped.
I see the Bundling with webpack section and webpack.config.js, but it's still not clear to me how to make use of that to further reduce bundle size. Any additional information would be appreciated.
Hi @ilyakamens,
I think you are doing everything right. Problem is that moment-timezone latest.json data still has ~180kB.
If you only leave the required timezones in this would reduce the size further.
Nonetheless there is still no reliable replacement to use correct timezones in the browser, which then would allow to remove the moment-timezone dependency.
Hi @commenthol,
Thanks for this great tool. I'd like to submit a feature request to expand the
pick
andomit
functionality when making a custom build. Specifically:pick
only certain US states (e.g., onlypick
holiday information for US + TX, andomit
the other state-specific holidays).omit
the holiday names in other languages (or topick
certain languages).I use this library to automatically display custom support / CX hours during my company's holidays. Even with the custom build (
holidays2json --pick US --min
), it adds 350KiB (80KiB zipped) to our bundle, which is quite a bit (it's the second-largest bundle in our app).Thank you for your consideration.
- Ilya
The text was updated successfully, but these errors were encountered: