-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Port missing Constructor tests #394
Comments
These tests have been ported. I was just looking at the count of tests in the browser and didn't realize there was an issue with htest and the deepest nested tests.
Tests that are causing the exception Lines 17 to 28 in 49455aa
|
Ah yes, the HTML view of these tests is an MVP and only deals with up to a certain level of nesting. The Node runner should work fine though. |
There are some failing tests This test fails because of a strict equality check: Line 35 in 49455aa
The test passes if I change === to == here: https://github.com/LeaVerou/htest/blob/70958deaf9bfd58ecb1f4ce247ffb7a9a3af2608/src/check.js#L43 Two other tests are failing because alpha is undefined. I'll submit a PR that fixes those two tests sometime today. |
Thank you! |
There are 5 tests in the old Constructor test suite and 3 in the new suite.
The text was updated successfully, but these errors were encountered: