-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XYZ color picker confuses 0..1 and 0..100% range #2
Comments
Maybe the max granularity shouldn't be 1 but .1? Take a look here and tell me how you think we should fix this generically. We can't just special case XYZ. |
let {name, range, refRange} = meta;
name = name || id;
range = range || refRange || [0, 100];
let [min, max] = range;
let step = (max - min) / 100;
if (step > 1) {
step = 1;
} Since |
Giving the relative XYZs a reference range of [0, 1] would also work. |
(confirming this UI bug still exists) |
Is this issue still present on https://apps.colorjs.io/picker/ ? |
Confirming that the issue still exists, because [0..1] and [0..100] are being confused |
What should the range be for each XYZ space? |
As I said earlier:
|
@DmitrySharabin could we integrate the |
@LeaVerou, I integrated the |
Thanks @DmitrySharabin! Is this issue present in |
Unfortunately, it does. As @svgeesus mentioned, since So, to solve this issue, we should probably declare ranges for those spaces. As Chris said:
|
Yeah, let's do that. |
The XYZ-d65 color picker has 0..100 scale but gives black for [0,0,0] and an oog color close to white for [1,1,1]; it is not possible to pick any other colors due to the slider granularity.
The text was updated successfully, but these errors were encountered: