Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure on Fedora with 6.1.0 #763

Open
limburgher opened this issue Jan 8, 2025 · 3 comments
Open

Test failure on Fedora with 6.1.0 #763

limburgher opened this issue Jan 8, 2025 · 3 comments

Comments

@limburgher
Copy link

Sample:

__________________ test_can_identify_dateutil[America/Merida] __________________

tzid = 'America/Merida'

@with_tzid
def test_can_identify_dateutil(tzid):
    """Check that all those dateutil timezones can be identified."""
    from dateutil.tz import gettz
  assert tzid in tzids_from_tzinfo(gettz(tzid))

E AssertionError: assert 'America/Merida' in ('America/Mexico_City', 'Mexico/General')
E + where ('America/Mexico_City', 'Mexico/General') = tzids_from_tzinfo(tzfile('/usr/share/zoneinfo/America/Merida'))
E + where tzfile('/usr/share/zoneinfo/America/Merida') = <dateutil.tz.tz.__get_gettz..GettzFunc object at 0x7f543477e270>('America/Merida')

src/icalendar/tests/test_timezone_identification.py:29: AssertionError

@niccokunzmann
Copy link
Member

Thank you! Could you tell me which system it is so it can be reproduced as well as pip list?

@limburgher
Copy link
Author

Fedora 42, rawhide mock.

@niccokunzmann
Copy link
Member

niccokunzmann commented Jan 10, 2025

Thank you! I think that the tests probably need adjusting:

  • new timezones should not be tested
  • timezones that are in the list but are not supported should also not be tested

That would create consistency across platforms, I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants