Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Solr's xPointField-fields #264

Open
adrianschulz opened this issue May 13, 2020 · 5 comments
Open

Support for Solr's xPointField-fields #264

adrianschulz opened this issue May 13, 2020 · 5 comments

Comments

@adrianschulz
Copy link
Contributor

While upgrading our search (collective.solr and Solr itself) I noticed that the xPointField-fields don't have any handlers. This results in error messages in Solr. For example
org.apache.solr.common.SolrException: Invalid Date String:'2499/12/31 00:00:00 GMT+2'
Since the TriexField-fields are deprecated in Solr I think collective.solr should also support the new version of these fieldtypes (xPointField-fields).

@adrianschulz
Copy link
Contributor Author

adrianschulz commented May 13, 2020

I fixed this for Float, Int and Date in #263 .

I tested only the fix for the Date (which was successful) in our environment so I would be happy if you could give me advice on how to test it properly to merge it.

@tisto
Copy link
Member

tisto commented May 13, 2020

@adrianschulz which version of Solr are you using? I tried to upgrade c.solr to Solr 8 the other day and ran into lots of deprecated features, so I stopped my efforts for now because it seemed to much work back then for my limited time. Though, I'd be happy to give this another shot at some point...

@adrianschulz
Copy link
Contributor Author

adrianschulz commented May 13, 2020

Currently I'm using 7.6.0. But I'm planning to switch to 7.7.3 in the next days and probably even to 8.5.1.
Coming from Solr 4.10.4 I had to change much but most of the deprectation-stuff (mostly fields) was quite easy I guess. I don't know how it is with other Solr-components like analyzers, filters or tokenizers but I think this could be difficult.

@adrianschulz
Copy link
Contributor Author

adrianschulz commented May 19, 2020

We are on 7.7.3. 8.5.1 did not work for us.

@tisto Do you have any advice regarding testing these changes?

@tisto
Copy link
Member

tisto commented May 19, 2020

7.7.3 should be safe. We use this version in production with c.solr. We have our Robot Framework tests that make sure the basics work. This would be a good starting point I guess. Are you using kitconcept.recipe.solr or did you write your own Solr config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants