New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow viewets pattern #34

Open

hvelarde opened this issue Aug 25, 2017 · 0 comments

Labels

Member

hvelarde commented Aug 25, 2017

seems the viewlet is not following the viewlet pattern as defined in the documentation.

don't declare the template on ZCML
review enabled/disabled
review tests

<browser:viewlet
    name="collective.newsticker"
    for="*"
    manager="plone.app.layout.viewlets.interfaces.IAboveContent"
    class="collective.newsticker.browser.NewsTickerViewlet"
    template="newsticker_viewlet.pt"
    permission="zope2.View"
    layer="collective.newsticker.interfaces.INewsTickerLayer"
    />

hvelarde added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment