CMake package registry breaks workspace isolation

[Levi-Armstrong]

We recently ran into issues with packages that leverage the CMake package registry feature. This feature breaks workspace isolation, should colcon automatically be passing the CMake disable flags?

  -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON
  -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON

[dirk-thomas]

I don't know enough about the CMake package registry to make a suggestion here. It sounds reasonable to me though.

Even with these flags embedded by default the user should be able to pass different values if desired.

Would you like to create a pull request for the proposed change?