Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab related bugs #21

Open
Nebelung-Dev opened this issue Apr 23, 2023 · 5 comments
Open

Tab related bugs #21

Nebelung-Dev opened this issue Apr 23, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Nebelung-Dev
Copy link

Nebelung-Dev commented Apr 23, 2023

Limit number of tabs. Too many will hide the close button.
image

View source on system pages opens and then closes.
image

@retronbv
Copy link

hate to be that guy but

- View source on system pages opens and than closes.
+ View source on system pages opens and then closes.

@cohenerickson
Copy link
Owner

cohenerickson commented Apr 24, 2023

The tab limit and overflow are good things to bring up, the reason that you cant view source on system pages is because the view-source page doesn't reference other system protocols when fetching resources. I want fix this by completely overhauling url and iframe handling with a custom service worker but I'm not quite sure how I want things to interact yet. This would also allow support for other proxies without much extra work.

@Nebelung-Dev
Copy link
Author

hate to be that guy but

- View source on system pages opens and than closes.
+ View source on system pages opens and then closes.

Ill do it for you <3

@cohenerickson
Copy link
Owner

I want to see what other people think the solution for opening too many tabs should be. I don't want to set a hard limit on the number of tabs as different screen sizes/aspect ratios may support showing more or less tabs at the same time. Looking at what Chrome does, one option would be to set a minimum size for the currently active tab in order to have room for the close button. This does stray away from the scrolling tabs bar on Firefox but I think it could be a temporary solution until the scrolling tabs get implemented.

@cohenerickson cohenerickson changed the title Bugs Tab related bugs Apr 30, 2023
@cohenerickson cohenerickson added the bug Something isn't working label May 1, 2023
@Nebelung-Dev
Copy link
Author

Scrolling is the way to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants