From 66313a0335aa4885049d5bb0128660e36e65bc15 Mon Sep 17 00:00:00 2001
From: Einar Omang <einar.omang@cognite.com>
Date: Mon, 9 Sep 2024 09:06:39 +0200
Subject: [PATCH] Avoid changing root-ness of assets

---
 Extractor/Pushers/PusherUtils.cs | 8 ++++----
 manifest.yml                     | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Extractor/Pushers/PusherUtils.cs b/Extractor/Pushers/PusherUtils.cs
index 6b47811cc..d558c0386 100644
--- a/Extractor/Pushers/PusherUtils.cs
+++ b/Extractor/Pushers/PusherUtils.cs
@@ -181,11 +181,11 @@ private static bool ShouldSetNewMetadata(FullConfig config, Dictionary<string, s
             if (update.Context && !newAsset.ParentId.IsNullNodeId)
             {
                 var parentId = extractor.GetUniqueId(newAsset.ParentId);
-                if (parentId != old.ParentExternalId)
+                // Do not move an asset from root to non-root or the other way around.
+                if (parentId is null == old.ParentExternalId is null
+                    && parentId != old.ParentExternalId)
                 {
-#pragma warning disable CS8604 // Possible null reference argument.
-                    assetUpdate.ParentExternalId = new UpdateNullable<string>(parentId);
-#pragma warning restore CS8604 // Possible null reference argument.
+                    assetUpdate.ParentExternalId = new UpdateNullable<string?>(parentId);
                 }
             }
 
diff --git a/manifest.yml b/manifest.yml
index 2cf57c80d..9b1c150bd 100644
--- a/manifest.yml
+++ b/manifest.yml
@@ -73,6 +73,7 @@ versions:
       fixed:
         - Avoid unnecessarily repeating pushes of timeseries and references.
         - Improve logging when the upload queue is full.
+        - Do not update whether or not an asset is a root node.
   "2.30.3":
     description: Fix various issues.
     changelog: