-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding support for doctrine/lexer 3 #473
Comments
Hey, yes I’m aware of this limitation, in fact, I even tried to upgrade but keeping support for all the versions seems to be a bit problematic due to bc breaks in the lexer. https://github.com/phplrt/phplrt seems to be a nice alternative |
Is there any reason to keep the support of the old versions of doctrine/lexer? Maybe there are other advantages of replacing the dependency? 🤔 |
honestly, the only reason is that I don't want php-matcher to force upgrades of orm/dbal at all projects that are using it. I would also prefer to detach from doctrine in general, not because it's bad, but because it's coupled with orm/dbal |
I think this is the reason I am unable to install it in a project with symfony 6.4:
Downgrading to: ... seems to work for now. |
hmm maybe as an intermediate step, we should actually upgrade lexer to ^3.0 🤔 I'm a bit busy currently but if anyone would like to bump it to 3.0 we could merge it and release I believe without a new version since it's not a BC break (meaning it can't break anyone code because composer would prevent update) |
resolved by #477 |
@norberttech any idea when the new version of |
hey, sorry for the daly, I was waiting for another PR to get merged. I still need to resolve some tools dependencies conflicts but I believe I should be able to push new release later today |
Thanks for the quick response. Sounds great! |
For now, it is not supported.
It prevents doctrine/orm package from being upgraded because it requires doctrine/lexer 3 and higher.
The text was updated successfully, but these errors were encountered: