Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the preview button to make editor WYSIWYG #1024

Closed
John-Paul-Larkin opened this issue Sep 23, 2024 · 4 comments
Closed

Remove the preview button to make editor WYSIWYG #1024

John-Paul-Larkin opened this issue Sep 23, 2024 · 4 comments
Assignees
Labels
editor good first issue Good for newcomers

Comments

@John-Paul-Larkin
Copy link
Member

John-Paul-Larkin commented Sep 23, 2024

Note : This issue will only be assigned to beginners.
If you have previously contributed to open source, or have experience, please filter out the issues tagged with "good first issue" and "beginner friendly".

Context

As part of "Meta issue : Editor #1022" we need to remove the preview button. This is a step towards making the editor WYSIWYG.

Expected Behavior

The button should be removed, along with any associated code.

Current Behavior

When we press the button it opens a preview of how the article will look when it is published. This implements all of the markdown shortcuts we added while editing the text.

Screenshots

Editor with preview button

Additional info

The alpha editor can be found at :

app>(app)>alpha>new

Any questions feel free to ask.

@Prakhar29Sharma
Copy link
Contributor

Hi @John-Paul-Larkin!
I'm new to open source, I would like to work on this.

@John-Paul-Larkin
Copy link
Member Author

Hi @John-Paul-Larkin! I'm new to open source, I would like to work on this.

Awesome Prakhar.
Thanks for taking this issue!

@Prakhar29Sharma
Copy link
Contributor

Hi @John-Paul-Larkin

Thank you for assigning this task to me. I’ve raised a pull request and would appreciate it if you could review it. Please let me know if there are any issues or further changes required.

This is my first time contributing to open source, so any feedback is welcome!

@John-Paul-Larkin
Copy link
Member Author

Thanks @Prakhar29Sharma

Great to see your first contribution. Hopefully the first of many.
We will review this PR and get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants