Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models #11

Closed
Ben-Baert opened this issue May 24, 2016 · 2 comments
Closed

Models #11

Ben-Baert opened this issue May 24, 2016 · 2 comments

Comments

@Ben-Baert
Copy link
Contributor

I'm currently refactoring the code. A number of thoughts regarding the models:

  • I think the Model in HabitModel and ActivityModel can be omitted, since the fact that it starts with a capital letter already indicates that it is one by convention. On top of this, since the models would be in their own module, this would be even more repetitive (models.HabitModel vs models.Habit).
  • I'm not sure whether Activity is semantically the best term for what it represents. I think Log is more appropriate, because a checkin doesn't always directly map to an activity, for instance in the example you gave in Different types of habits #9 (nr of meetings/week). It often does, but not necessarily.

These are some of the issues directly relating to the refactoring, that is, making the code cleaner without adding more features. There are of course other proposals relating to the models, such as #9, but I won't deal with those just yet.

@codito
Copy link
Owner

codito commented May 25, 2016

Agree with these thoughts. #9 should be separate from this refactoring.

@codito
Copy link
Owner

codito commented Jan 7, 2018

Models are already a separate module. We've dropped Model from the table names, migrations are in place for next version. Closing this issue.

@codito codito closed this as completed Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants