You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm currently refactoring the code. A number of thoughts regarding the models:
I think the Model in HabitModel and ActivityModel can be omitted, since the fact that it starts with a capital letter already indicates that it is one by convention. On top of this, since the models would be in their own module, this would be even more repetitive (models.HabitModel vs models.Habit).
I'm not sure whether Activity is semantically the best term for what it represents. I think Log is more appropriate, because a checkin doesn't always directly map to an activity, for instance in the example you gave in Different types of habits #9 (nr of meetings/week). It often does, but not necessarily.
These are some of the issues directly relating to the refactoring, that is, making the code cleaner without adding more features. There are of course other proposals relating to the models, such as #9, but I won't deal with those just yet.
The text was updated successfully, but these errors were encountered:
I'm currently refactoring the code. A number of thoughts regarding the models:
Model
inHabitModel
andActivityModel
can be omitted, since the fact that it starts with a capital letter already indicates that it is one by convention. On top of this, since the models would be in their own module, this would be even more repetitive (models.HabitModel
vsmodels.Habit
).Activity
is semantically the best term for what it represents. I thinkLog
is more appropriate, because a checkin doesn't always directly map to an activity, for instance in the example you gave in Different types of habits #9 (nr of meetings/week). It often does, but not necessarily.These are some of the issues directly relating to the refactoring, that is, making the code cleaner without adding more features. There are of course other proposals relating to the models, such as #9, but I won't deal with those just yet.
The text was updated successfully, but these errors were encountered: