Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline tool from the documentation doesn't work in latest version #2827

Open
sarabourdon-rheo opened this issue Sep 23, 2024 · 3 comments
Open

Comments

@sarabourdon-rheo
Copy link

Hi,

I'm following the tutorial from the docs to create a marker inline tool. With the exact same code, when I click on the marker button, the color picker is quickly displayed, then disappears, so it can't be used.
The doc was last updated several years ago, and works fine with older versions of Editor.js, but not with latest ones. It makes it harder to create my own inline tool.

Steps to reproduce:

  1. Try this code sandbox with the tool code from the docs https://codesandbox.io/p/sandbox/editor-js-forked-pyk98w
  2. Add some text and add a mark from inline tool
    image
  3. Color picker is diplayed but disappears.
  4. Go to package.json and change editorjs version to 2.15.1
    "@editorjs/editorjs": "2.15.1",
  5. If you try again, the color picker of the marker works well.

Editor.js version:
2.30.6

The color plugin I use doesn't work anymore since latest Editor.js updates, see these issues:
flaming-cl/editorjs-text-color-plugin#36
flaming-cl/editorjs-text-color-plugin#35 (comment)

So I don't know how to implement a color picker with Editor.js v2.30+.

Thanks

@neSpecc
Copy link
Member

neSpecc commented Oct 28, 2024

Please, clarify. The problem is related to code in our tutorial or to the 3rd party color plugin?

@sarabourdon-rheo
Copy link
Author

The code in the documentation tutorial to create a marker inline tool doesn't work : https://editorjs.io/inline-tool-user-interaction/

I also have similar issues with 3rd party plugin, but here my point is that the documentation example is not working.

@neSpecc
Copy link
Member

neSpecc commented Oct 28, 2024

You can look at this example while we'll check and update docs

https://github.com/editor-js/marker/blob/master/src/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants