Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Modules #312

Open
matifali opened this issue Oct 7, 2024 · 1 comment
Open

Nested Modules #312

matifali opened this issue Oct 7, 2024 · 1 comment

Comments

@matifali
Copy link
Member

matifali commented Oct 7, 2024

Context

We now have modules with a lot of duplicate code and only differ in core functionality.

An example is our vault and jfrog modules. We have three vault modules that install the CLI and then authenticate the user using the module-specific method.

Similarly, our jfrog-oauth and jfrog-token modules also overlap a lot of functionality and can benefit from a shared config.

Proposal

Start creating shared modules that other modules will use to provide the common functionality.

To start, we can create a common module vault-cli, which, when used in the root of a template, will install the vault CLI to the template. Other vault modules can use the same standard module to install the CLI. This will help simplify and maintain modules easily and prevent feature drift.

@coder-labeler coder-labeler bot added enhancement module-idea A new module idea or suggestion labels Oct 7, 2024
@phorcys420
Copy link
Member

This would be great!

I wanted to do something similar in #307 where modules would call that other module to install dev container features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants