Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add envbuilder install-feature command #361

Open
phorcys420 opened this issue Sep 26, 2024 · 2 comments
Open

feat: add envbuilder install-feature command #361

phorcys420 opened this issue Sep 26, 2024 · 2 comments

Comments

@phorcys420
Copy link
Member

I am looking into adding a module to the registry that would let template administrators install Dev Container features inside Coder Workspaces (even outside of envbuilder).

I think envbuilder already has the logic to install features, so I think the most logical thing to do would be to create a separate command just to install a given feature.

While Dev Container features are only shell scripts, there is still some logic needed for arguments in the manifest, e.g dependsOn.

See coder/modules#307 for more context.

Usage

envbuilder install-feature <source>
Ideally, source could be either a Git URL, a local folder or a path to an image.


cc: @johnstcn

@mafredri
Copy link
Member

How would this module work, would it require the envbuilder binary to be present or will it download and install envbuilder first, then attempt to install the feature?

One issue with installing features is permissions, i.e. envbuilder probably has to be run with sudo to work properly, otherwise users may end up with none or only partially working features.

That said, I think this is a pretty cool feature request, thanks for opening the ticket @phorcys420.

@phorcys420
Copy link
Member Author

How would this module work, would it require the envbuilder binary to be present or will it download and install envbuilder first, then attempt to install the feature?

Probably download and install, but i haven't really decided.

One issue with installing features is permissions, i.e. envbuilder probably has to be run with sudo to work properly, otherwise users may end up with none or only partially working features.

Devcontainer features expect to be run as root anyways so it will always need sudo access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants